Re: [PATCH] mfd: davinci_voicecodec: fix possible null-ptr-deref davinci_vc_probe()

From: Lee Jones
Date: Mon May 23 2022 - 09:53:12 EST


On Tue, 26 Apr 2022, Yang Yingliang wrote:

> It will cause null-ptr-deref when using 'res', if platform_get_resource()
> returns NULL, so move using 'res' after devm_ioremap_resource() that
> will check it to avoid null-ptr-deref.
> And use devm_platform_get_and_ioremap_resource() to simplify code.
>
> Fixes: b5e29aa880be ("mfd: davinci_voicecodec: Remove pointless #include")
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
> ---
> drivers/mfd/davinci_voicecodec.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)

Applied, thanks.

--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog