Re: [PATCH v1 04/19] tty: serial: 8250: Add NPCM845 UART support

From: Arnd Bergmann
Date: Mon May 23 2022 - 07:43:39 EST


On Sun, May 22, 2022 at 5:50 PM Tomer Maimon <tmaimon77@xxxxxxxxx> wrote:
> +++ b/drivers/tty/serial/8250/8250_of.c
> @@ -333,6 +333,7 @@ static const struct of_device_id of_platform_serial_table[] = {
> { .compatible = "ti,da830-uart", .data = (void *)PORT_DA830, },
> { .compatible = "nuvoton,wpcm450-uart", .data = (void *)PORT_NPCM, },
> { .compatible = "nuvoton,npcm750-uart", .data = (void *)PORT_NPCM, },
> + { .compatible = "nuvoton,npcm845-uart", .data = (void *)PORT_NPCM, },
> { /* end of list */ },

If these are compatible devices, it's usually easier to claim
compatibility with both the specific chip and the older model
as a fallback, to avoid driver changes. This seems to apply to
the timer and watchdog devices as well.

Arnd