Re: [PATCH v2 4/5] clang-format: Fix empty curly braces
From: Mickaël Salaün
Date: Mon May 23 2022 - 07:15:08 EST
On 20/05/2022 19:15, Miguel Ojeda wrote:
On Fri, May 6, 2022 at 6:00 PM Mickaël Salaün <mic@xxxxxxxxxxx> wrote:
SplitEmptyFunction [1] should be false to not add a new line in an empty
function body. This follows the current kernel coding style.
I don't think this is correct. Checking headers in `include/linux/`, I
see ~70 using {} (when not in the same line as the signature), and
~700 in different lines. In `kernel/`, it is even more pronounced: 4
vs. ~200.
Am I missing something?
You're right, it is not consistent across all kernel code. Using
one-liners is easier but after a wider counting for *.c and *.h with
5.18 I get:
- 187 for "\n{ }\n"
- 196 for "\n{}\n"
- 1963 for ") *{}\n"
- 4554 for "\n{\n}"
Please ignore this patch, I'll do the same for my changes.
Regards,
Mickaël