[PATCH] firmware: Avoid leak OF node on error

From: cgel . zte
Date: Mon May 23 2022 - 07:13:36 EST


From: Minghao Chi <chi.minghao@xxxxxxxxxx>

The OF node should be put before returning error in stratix10_svc_init(),
otherwise node's refcount will be leaked.

Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
Signed-off-by: Minghao Chi <chi.minghao@xxxxxxxxxx>
---
drivers/firmware/stratix10-svc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/stratix10-svc.c b/drivers/firmware/stratix10-svc.c
index 14663f671323..3facd5dfb617 100644
--- a/drivers/firmware/stratix10-svc.c
+++ b/drivers/firmware/stratix10-svc.c
@@ -1109,10 +1109,10 @@ static int __init stratix10_svc_init(void)
return -ENODEV;

np = of_find_matching_node(fw_np, stratix10_svc_drv_match);
+ of_node_put(np);
if (!np)
return -ENODEV;

- of_node_put(np);
ret = of_platform_populate(fw_np, stratix10_svc_drv_match, NULL, NULL);
if (ret)
return ret;
--
2.25.1