Re: [PATCH v3 4/4] soc: mediatek: svs: add support for mt8195

[AngeloGioacchino Del Regno]

Il 23/05/22 10:40, Tim Chang ha scritto:
> From: Jia-Wei Chang <jia-wei.chang@xxxxxxxxxxxx>
>
> To support svs on MT8195, add corresponding bank information, platform
> data, probe and parsing function.
>
> Signed-off-by: Jia-Wei Chang <jia-wei.chang@xxxxxxxxxxxx>



> ---
>   drivers/soc/mediatek/mtk-svs.c | 151 +++++++++++++++++++++++++++++++++
>   1 file changed, 151 insertions(+)
>
> diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
> index 656d0361ff7d..bb5021648143 100644
> --- a/drivers/soc/mediatek/mtk-svs.c
> +++ b/drivers/soc/mediatek/mtk-svs.c
> @@ -1680,6 +1680,89 @@ static int svs_bank_resource_setup(struct svs_platform *svsp)

..snip..

> @@ -2559,6 +2697,16 @@ static struct svs_bank svs_mt8183_banks[] = {
>   	},
>   };
>   
> +static const struct svs_platform_data svs_mt8195_platform_data = {
> +	.name = "mt8195-svs",
> +	.banks = svs_mt8195_banks,
> +	.efuse_parsing = svs_mt8195_efuse_parsing,
> +	.probe = svs_mt8192_platform_probe,
> +	.irqflags = IRQF_TRIGGER_HIGH,

Interrupt flags are specified in devicetree; avoid declaring irqflags.

After that:

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>