RE: [PATCH V7 2/4] cpufreq: amd-pstate: Add test module for amd-pstate driver

[Meng, Li (Jassmine)]

[AMD Official Use Only - General]



> -----Original Message-----
> From: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> Sent: Monday, May 23, 2022 3:32 PM
> To: Meng, Li (Jassmine) <Li.Meng@xxxxxxx>
> Cc: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>; Huang, Ray
> <Ray.Huang@xxxxxxx>; linux-pm@xxxxxxxxxxxxxxx; Rafael J . Wysocki
> <rafael.j.wysocki@xxxxxxxxx>; Fontenot, Nathan
> <Nathan.Fontenot@xxxxxxx>; Sharma, Deepak
> <Deepak.Sharma@xxxxxxx>; Deucher, Alexander
> <Alexander.Deucher@xxxxxxx>; Limonciello, Mario
> <Mario.Limonciello@xxxxxxx>; Su, Jinzhou (Joe) <Jinzhou.Su@xxxxxxx>;
> Yuan, Perry <Perry.Yuan@xxxxxxx>; Du, Xiaojian <Xiaojian.Du@xxxxxxx>;
> Borislav Petkov <bp@xxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH V7 2/4] cpufreq: amd-pstate: Add test module for amd-
> pstate driver
> 
> [CAUTION: External Email]
> 
> On 22-05-22, 19:54, Meng Li wrote:
> > Add amd-pstate-ut module, which is conceptually out-of-tree module and
> > provides ways for selftests/amd-pstate driver to test various kernel
> > module-related functionality. This module will be expected by some of
> > selftests to be present and loaded.
> >
> > Signed-off-by: Meng Li <li.meng@xxxxxxx>
> > Acked-by: Huang Rui <ray.huang@xxxxxxx>
> > ---
> >  drivers/cpufreq/Kconfig.x86     |   7 +
> >  drivers/cpufreq/Makefile        |   1 +
> >  drivers/cpufreq/amd-pstate-ut.c | 293
> > ++++++++++++++++++++++++++++++++
> >  3 files changed, 301 insertions(+)
> >  create mode 100644 drivers/cpufreq/amd-pstate-ut.c
> 
> I wonder if this should be moved to selftest directories instead ?
> 
> --
> Viresh

Thanks.
We took Shuah's comments and put test driver under drivers/cpufreq.

[Meng, Li (Jassmine)]