Re: [PATCH 11/22] KVM: x86: hyper-v: replace bitmap_weight() with hweight64()

From: Yury Norov
Date: Sun May 22 2022 - 13:39:30 EST


On Sun, May 22, 2022 at 07:53:57AM -0700, Guenter Roeck wrote:
> On Tue, May 10, 2022 at 08:47:39AM -0700, Yury Norov wrote:
> > kvm_hv_flush_tlb() applies bitmap API to a u64 variable valid_bank_mask.
> > Since valid_bank_mask has a fixed size, we can use hweight64() and avoid
> > excessive bloating.
>
> In kvm_hv_send_ipi(), valid_bank_mask is unsigned long, not u64.
>
> This results in:
>
> arch/x86/kvm/hyperv.c: In function 'kvm_hv_send_ipi':
> include/asm-generic/bitops/const_hweight.h:21:76: error: right shift count >= width of type
>
> on all 32-bit builds.
>
> Guenter

Hi Guenter,

The fix is in Paolo's tree:
https://lore.kernel.org/lkml/20220519171504.1238724-1-yury.norov@xxxxxxxxx/T/

Thanks,
Yury