Re: [PATCH] ath10k: do not enforce interrupt trigger type

From: Kalle Valo
Date: Sun May 22 2022 - 08:22:30 EST


Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote:

> Interrupt line can be configured on different hardware in different way,
> even inverted. Therefore driver should not enforce specific trigger
> type - edge rising - but instead rely on Devicetree to configure it.
>
> All Qualcomm DTSI with WCN3990 define the interrupt type as level high,
> so the mismatch between DTSI and driver causes rebind issues:
>
> $ echo 18800000.wifi > /sys/bus/platform/drivers/ath10k_snoc/unbind
> $ echo 18800000.wifi > /sys/bus/platform/drivers/ath10k_snoc/bind
> [ 44.763114] irq: type mismatch, failed to map hwirq-446 for interrupt-controller@17a00000!
> [ 44.763130] ath10k_snoc 18800000.wifi: error -ENXIO: IRQ index 0 not found
> [ 44.763140] ath10k_snoc 18800000.wifi: failed to initialize resource: -6
>
> Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.2.0.c8-00009-QCAHLSWSC8180XMTPLZ-1
> Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.2.0-01387-QCAHLSWMTPLZ-1
>
> Fixes: c963a683e701 ("ath10k: add resource init and deinit for WCN3990")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Tested-by: Steev Klimaszewski <steev@xxxxxxxx>
> Signed-off-by: Kalle Valo <quic_kvalo@xxxxxxxxxxx>

Patch applied to ath-next branch of ath.git, thanks.

1ee6c5abebd3 ath10k: do not enforce interrupt trigger type

--
https://patchwork.kernel.org/project/linux-wireless/patch/20220513151516.357549-1-krzysztof.kozlowski@xxxxxxxxxx/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches