Re: [PATCH v3 1/2] tpm: Add tpm_tis_i2c backend for tpm_tis_core

From: Krzysztof Kozlowski
Date: Sun May 22 2022 - 04:30:21 EST


On 20/05/2022 19:24, Alexander Steffen wrote:
>
> +MODULE_DEVICE_TABLE(i2c, tpm_tis_i2c_id);
> +
> +#ifdef CONFIG_OF
> +static const struct of_device_id of_tis_i2c_match[] = {
> + { .compatible = "infineon,slb9673", },
> + { .compatible = "tcg,tpm_tis-i2c", },

Please run checkpatch on your patches. You add undocumented compatibles.

Without bindings, new compatibles and properties cannot be accepted, so NAK.

Best regards,
Krzysztof