Re: [PATCH 1/4] dt-bindings: regulator: Add bindings for MT6331 regulator

From: Krzysztof Kozlowski
Date: Sat May 21 2022 - 10:40:21 EST


On 20/05/2022 15:33, AngeloGioacchino Del Regno wrote:
> Add the bindings for the regulators found in the MT6331 PMIC.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> ---
> .../bindings/regulator/mt6331-regulator.yaml | 272 ++++++++++++++++++
> 1 file changed, 272 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/regulator/mt6331-regulator.yaml
>
> diff --git a/Documentation/devicetree/bindings/regulator/mt6331-regulator.yaml b/Documentation/devicetree/bindings/regulator/mt6331-regulator.yaml
> new file mode 100644
> index 000000000000..333c74cdbcbe
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/mt6331-regulator.yaml

mediatek,mt6331-regulator.yaml

> @@ -0,0 +1,272 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/mt6331-regulator.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MT6331 Regulator from MediaTek Integrated
> +
> +maintainers:
> + - AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> +
> +description: |
> + List of regulators provided by this controller.

I don't understand this sentence in the description.

> It is named
> + according to its regulator type, buck_<name> and ldo_<name>.
> + MT6331 regulators node should be sub node of the MT6397 MFD node.
> +


Best regards,
Krzysztof