Re: [PATCH 3/4] vhost-vdpa: uAPI to stop the device
From: kernel test robot
Date: Sat May 21 2022 - 01:22:04 EST
Hi "Eugenio,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on mst-vhost/linux-next]
[also build test WARNING on next-20220520]
[cannot apply to horms-ipvs/master linus/master v5.18-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Eugenio-P-rez/Implement-vdpasim-stop-operation/20220521-012742
base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
config: hexagon-randconfig-r041-20220519 (https://download.01.org/0day-ci/archive/20220521/202205211317.rqYkIW8B-lkp@xxxxxxxxx/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project e00cbbec06c08dc616a0d52a20f678b8fbd4e304)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/bd6562e0d85e8d689d30226bcc0f43246e27e4b5
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Eugenio-P-rez/Implement-vdpasim-stop-operation/20220521-012742
git checkout bd6562e0d85e8d689d30226bcc0f43246e27e4b5
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/vhost/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All warnings (new ones prefixed by >>):
>> drivers/vhost/vdpa.c:493:25: warning: variable 'stop' is uninitialized when used here [-Wuninitialized]
return ops->stop(vdpa, stop);
^~~~
drivers/vhost/vdpa.c:485:10: note: initialize the variable 'stop' to silence this warning
int stop;
^
= 0
1 warning generated.
vim +/stop +493 drivers/vhost/vdpa.c
480
481 static long vhost_vdpa_stop(struct vhost_vdpa *v, u32 __user *argp)
482 {
483 struct vdpa_device *vdpa = v->vdpa;
484 const struct vdpa_config_ops *ops = vdpa->config;
485 int stop;
486
487 if (!ops->stop)
488 return -EOPNOTSUPP;
489
490 if (copy_to_user(argp, &stop, sizeof(stop)))
491 return -EFAULT;
492
> 493 return ops->stop(vdpa, stop);
494 }
495
--
0-DAY CI Kernel Test Service
https://01.org/lkp