Re: [PATCH bpf-next v1 3/5] bpf: Introduce cgroup iter

From: Yonghong Song
Date: Fri May 20 2022 - 20:59:53 EST




On 5/20/22 3:57 PM, Tejun Heo wrote:
Hello,

On Fri, May 20, 2022 at 03:19:19PM -0700, Alexei Starovoitov wrote:
We have bpf_map iterator that walks all bpf maps.
When map iterator is parametrized with map_fd the iterator walks
all elements of that map.
cgroup iterator should have similar semantics.
When non-parameterized it will walk all cgroups and their descendent
depth first way. I believe that's what Yonghong is proposing.
When parametrized it will start from that particular cgroup and
walk all descendant of that cgroup only.
The bpf prog can stop the iteration right away with ret 1.
Maybe we can add two parameters. One -> cgroup_fd to use and another ->
the order of iteration css_for_each_descendant_pre vs _post.
wdyt?

Sounds perfectly reasonable to me.

This works for me too. Thanks!


Thanks.