Re: [v2 1/3] arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1

From: Stephen Boyd
Date: Fri May 20 2022 - 17:02:02 EST


Quoting Doug Anderson (2022-05-20 13:39:21)
> On Fri, May 20, 2022 at 1:38 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote:
> >
> > Quoting Judy Hsiao (2022-05-20 09:10:02)
> > > +};
> > > +
> > > +&mi2s1_sclk {
> > > + drive-strength = <6>;
> > > + bias-disable;
> >
> > Is there an external pull on this line? If so please add that details as
> > a comment like we do for other external pulls.
>
> Actually, I think they are output lines, which is why they have a
> drive-strength. I think for output lines we don't usually comment
> about why we're disabling the pulls, only for input lines?

Ok makes sense. Even for an open drain signal it would be an "input" so
that rule still applies?