Re: [PATCH] arm64: dts: qcom: sc7280: Enable wifi for Chrome OS boards

[Matthias Kaehlcke]

On Fri, May 20, 2022 at 01:07:53PM -0700, Doug Anderson wrote:
> Hi,
> 
> On Wed, May 18, 2022 at 3:53 PM Matthias Kaehlcke <mka@xxxxxxxxxxxx> wrote:
> >
> > Enable the 'wifi' and 'remoteproc_wpss' nodes for all sc7280
> > based Chrome OS boards. Delete the corresponding entries from
> > sc7280-idp.dtsi since this file includes sc7280-chrome-common.dtsi.
> >
> > Signed-off-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>
> > ---
> >
> >  arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi | 13 +++++++++++++
> >  arch/arm64/boot/dts/qcom/sc7280-idp.dtsi           | 11 -----------
> >  2 files changed, 13 insertions(+), 11 deletions(-)
> 
> Looks right to me. You're also adding the firmware-name, but:
> 
> * That's in the bindings.
> 
> * The name you have there matches what's in the linux-firmware
> repository in commit 0d5e9f7e0aa1 ("ath11k: WCN6750 hw1.0: add to
> WLAN.MSL.1.0.1-00887-QCAMSLSWPLZ-1")
> 
> Hmmm, I guess one question is whether this same firmware would also be
> used for other, non-Chrome sc7280 devices. If so then the
> firmware-name probably belongs straight in sc7280.dtsi? I suppose that
> could always happen in a future change if/when we have other sc7280
> devices and it's clear that they're sharing firmware. Thus:

It could go either way. One of our wifi engineers mentioned that his
contact at QC said the FW should reside directly in /lib/firmware, not
in any sub-directory, which would be odd, but up to them ;-)

> Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>

Thanks!