Re: [PATCH] splice: allow direct splicing with chardevs

[Jens Axboe]

On 5/20/22 3:57 AM, Jason A. Donenfeld wrote:
> The original direct splicing mechanism from Jens required the input to
> be a regular file because it was avoiding the special socket case. It
> also recognized blkdevs as being close enough to a regular file. But it
> forgot about chardevs, which behave the same way and work fine here.
> 
> This commit adds the missing S_ISCHR condition so that chardevs such as
> /dev/urandom can be directly spliced without strangely returning
> -EINVAL.

Should be fine to turn this on for char devices:

Reviewed-by: Jens Axboe <axboe@xxxxxxxxx>

-- 
Jens Axboe