Re: [RFC PATCH v3 1/6] [PATCH 1/6] mm: refactor of vma_merge()

From: Kirill A. Shutemov
Date: Fri May 20 2022 - 09:26:19 EST


On Mon, May 16, 2022 at 02:54:00PM +0200, Jakub Matěna wrote:
> Refactor vma_merge() to make it shorter, more understandable and
> suitable for tracing of successful merges that are made possible by
> following patches in the series. Main change is the elimination of code
> duplicity in the case of merge next check. This is done by first doing
> checks and caching the results before executing the merge itself. Exit
> paths are also unified.
>
> Signed-off-by: Jakub Matěna <matenajakub@xxxxxxxxx>

Okay, this looks good:

Acked-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>

I would also consider renaming 'area' to 'vma'. 'area' feels wrong to me,
but maybe it is only me.

--
Kirill A. Shutemov