Re: [PATCH v2 1/2] ASoC: amd: acp: Add support for nau8825 and max98360 card

From: Mark Brown
Date: Fri May 20 2022 - 08:42:38 EST


On Thu, May 19, 2022 at 11:25:21AM +0530, V sujith kumar Reddy wrote:
> We have new platform with nau8825 as a primary codec and max98360 as an
> amp codec. Add machine struct to register sof audio based sound card
> on such Chrome machine.

This breaks an x86 allmodconfig build:

/build/stage/linux/sound/soc/amd/acp/acp-mach-common.c: In function ‘acp_card_nau8825_init’:
/build/stage/linux/sound/soc/amd/acp/acp-mach-common.c:479:15: error: too many arguments to function ‘snd_soc_card_jack_new’
479 | ret = snd_soc_card_jack_new(card, "Headset Jack",
| ^~~~~~~~~~~~~~~~~~~~~
In file included from /build/stage/linux/include/sound/soc.h:1362,
from /build/stage/linux/sound/soc/amd/acp/acp-mach-common.c:20:
/build/stage/linux/include/sound/soc-card.h:18:5: note: declared here
18 | int snd_soc_card_jack_new(struct snd_soc_card *card, const char *id, int type,
| ^~~~~~~~~~~~~~~~~~~~~
make[5]: *** [/build/stage/linux/scripts/Makefile.build:288: sound/soc/amd/acp/acp-mach-common.o] Error 1
make[5]: Target '__build' not remade because of errors.
make[4]: *** [/build/stage/linux/scripts/Makefile.build:550: sound/soc/amd/acp] Error 2
make[4]: Target '__build' not remade because of errors.
make[3]: *** [/build/stage/linux/scripts/Makefile.build:550: sound/soc/amd] Error 2
make[3]: Target '__build' not remade because of errors.
make[2]: *** [/build/stage/linux/scripts/Makefile.build:550: sound/soc] Error 2
make[2]: Target '__build' not remade because of errors.
make[1]: *** [/build/stage/linux/Makefile:1834: sound] Error 2
make[1]: Target '__all' not remade because of errors.
make: *** [Makefile:219: __sub-make] Error 2
make: Target '__all' not remade because of errors.
make --silent --keep-going --jobs=14 O=/tmp/build-work INSTALL_MOD_STRIP=1 INSTALL_MOD_PATH=/tmp/build-work/modinstall ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu- modules_install
sed: can't read modules.order: No such file or directory
make[1]: *** [/build/stage/linux/Makefile:1467: __modinst_pre] Error 2
make[1]: Target 'modules_install' not remade because of errors.
make: *** [Makefile:219: __sub-make] Error 2
make: Target 'modules_install' not remade because of errors.

Attachment: signature.asc
Description: PGP signature