Re: [PATCH v1 1/2] tools/nolibc/stdlib: Support overflow checking for older compiler versions

From: Alviro Iskandar Setiawan
Date: Fri May 20 2022 - 07:30:53 EST


On Fri, May 20, 2022 at 12:21 AM Ammar Faizi <ammarfaizi2@xxxxxxxxxxx> wrote:
> Previously, we used __builtin_mul_overflow() to check for overflow in
> the multiplication operation in the calloc() function. However, older
> compiler versions don't support this built-in. This patch changes the
> overflow checking mechanism to make it work on any compiler version
> by using a division method to check for overflow. No functional change
> intended. While in there, remove the unused variable `void *orig`.
>
> Link: https://lore.kernel.org/lkml/20220330024114.GA18892@xxxxxx
> Suggested-by: Willy Tarreau <w@xxxxxx>
> Cc: Alviro Iskandar Setiawan <alviro.iskandar@xxxxxxxxxxx>
> Signed-off-by: Ammar Faizi <ammarfaizi2@xxxxxxxxxxx>

Reviewed-by: Alviro Iskandar Setiawan <alviro.iskandar@xxxxxxxxxxx>

tq

-- Viro