Re: [PATCH net-next v5 12/13] ARM: dts: r9a06g032: describe switch

From: Clément Léger
Date: Fri May 20 2022 - 04:19:31 EST


Le Thu, 19 May 2022 21:28:12 +0300,
Vladimir Oltean <olteanv@xxxxxxxxx> a écrit :

> Does the switch port count depend on anything? If it doesn't, maybe you
> could add the "ethernet-ports" node and all the ports here, with status
> = "disabled", so that board files don't need to spell them out each time?

Port count does not depends on anything, it's always fixed so indeed, it
would be a good idea to provide all the ports as disabled.

> I'm also thinking you could define the fixed-link and phy-mode = "internal"
> property of the CPU port with this occasion. That surely isn't a
> per-board thing.

Totally.

Thanks,

--
Clément Léger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com