Re: [PATCH] Revert "workqueue: remove unused cancel_work()"

From: Christian König
Date: Fri May 20 2022 - 02:22:50 EST


Am 20.05.22 um 02:47 schrieb Lai Jiangshan:
On Thu, May 19, 2022 at 11:04 PM Andrey Grodzovsky
<andrey.grodzovsky@xxxxxxx> wrote:
See this patch-set https://www.spinics.net/lists/amd-gfx/msg78514.html, specifically patch
'drm/amdgpu: Switch to delayed work from work_struct.

I will just reiterate here -

We need to be able to do non blocking cancel pending reset works
from within GPU reset. Currently kernel API allows this only
for delayed_work and not for work_struct.

I'm OK with the change.

With an updated changelog:

Reviewed-by: Lai Jiangshan<jiangshanlai@xxxxxxxxx>

Good morning guys,

for the patch itself Reviewed-by: Christian König <christian.koenig@xxxxxxx>

And just for the record: We plan to push this upstream through the drm branches, if anybody has any objections to that please speak up.

Thanks,
Christian.



Thanks
Lai