RE: [PATCH net v3] net: macb: Fix PTP one step sync support

[Harini Katakam]

> -----Original Message-----
> From: Paolo Abeni <pabeni@xxxxxxxxxx>
> Sent: Thursday, May 19, 2022 11:48 PM
> To: Harini Katakam <harinik@xxxxxxxxxx>; nicolas.ferre@xxxxxxxxxxxxx;
> davem@xxxxxxxxxxxxx; richardcochran@xxxxxxxxx;
> claudiu.beznea@xxxxxxxxxxxxx; kuba@xxxxxxxxxx; edumazet@xxxxxxxxxx
> Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Michal Simek
> <michals@xxxxxxxxxx>; harinikatakamlinux@xxxxxxxxx; Radhey Shyam
> Pandey <radheys@xxxxxxxxxx>
> Subject: Re: [PATCH net v3] net: macb: Fix PTP one step sync support
> 
> On Wed, 2022-05-18 at 22:37 +0530, Harini Katakam wrote:
> > PTP one step sync packets cannot have CSUM padding and insertion in SW
> > since time stamp is inserted on the fly by HW.
> > In addition, ptp4l version 3.0 and above report an error when skb
> > timestamps are reported for packets that not processed for TX TS after
> > transmission.
> > Add a helper to identify PTP one step sync and fix the above two
> > errors. Add a common mask for PTP header flag field "twoStepflag".
> > Also reset ptp OSS bit when one step is not selected.
> >
> > Fixes: ab91f0a9b5f4 ("net: macb: Add hardware PTP support")
> > Fixes: 653e92a9175e ("net: macb: add support for padding and fcs
> > computation")
> > Signed-off-by: Harini Katakam <harini.katakam@xxxxxxxxxx>
> > Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xxxxxxxxxx>
> 
> I'm sorry, but I cut the -net PR to Linus too early for this, so the fix will have to
> wait for a little more (no need to repost!) and even more pause will be
> required for the net-next follow-up.
> 
> Sorry for the inconvenince,

Thanks Paolo. No problem, will wait and send net-next follow up.

Regards,
Harini