Re: [PATCH v1 0/2] nolibc updates for Linux 5.20

From: Willy Tarreau
Date: Fri May 20 2022 - 00:24:03 EST


On Fri, May 20, 2022 at 12:21:14AM +0700, Ammar Faizi wrote:
> Not much to do this time. Only small nolibc updates here. There are two
> patches in this series.
>
> 1. Address Willy's comment about overflow checking in the multiplication
> operation [1]. This patch supports overflow checking for older
> compiler versions. Currently, we use `__builtin_mul_overflow()` that
> doesn't exist in older compiler versions. Instead of using this
> built-in, use a simple division to check for overflow in the `calloc()`
> function.
>
> 2. The compiler can warn us about wrong `printf` arguments. This patch
> enables the warnings. Currently, only two functions use this attribute:
> `printf` and `fprintf`.

Paul, in summary I'm perfectly fine with the whole series, you can take it.

Thanks!
Willy