Re: [PATCH] FS: nfs: removed goto statement
From: kernel test robot
Date: Thu May 19 2022 - 23:59:48 EST
Hi Javier,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on trondmy-nfs/linux-next]
[also build test WARNING on v5.18-rc7 next-20220519]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Javier-Abrego/FS-nfs-removed-goto-statement/20220520-065648
base: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
config: i386-randconfig-a015 (https://download.01.org/0day-ci/archive/20220520/202205201106.ONDKuLvW-lkp@xxxxxxxxx/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project e00cbbec06c08dc616a0d52a20f678b8fbd4e304)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/99dd76e4af5d61f97c1981a240cbd1d86908ac8e
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Javier-Abrego/FS-nfs-removed-goto-statement/20220520-065648
git checkout 99dd76e4af5d61f97c1981a240cbd1d86908ac8e
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash fs/nfs/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All warnings (new ones prefixed by >>):
>> fs/nfs/nfs42xattr.c:754:3: warning: variable 'entry' is uninitialized when used here [-Wuninitialized]
entry->bucket = &cache->buckets[0];
^~~~~
fs/nfs/nfs42xattr.c:743:32: note: initialize the variable 'entry' to silence this warning
struct nfs4_xattr_entry *entry;
^
= NULL
1 warning generated.
vim +/entry +754 fs/nfs/nfs42xattr.c
95ad37f90c338e Frank van der Linden 2020-06-23 735
95ad37f90c338e Frank van der Linden 2020-06-23 736 /*
95ad37f90c338e Frank van der Linden 2020-06-23 737 * Cache listxattr output, replacing any possible old one.
95ad37f90c338e Frank van der Linden 2020-06-23 738 */
95ad37f90c338e Frank van der Linden 2020-06-23 739 void nfs4_xattr_cache_set_list(struct inode *inode, const char *buf,
95ad37f90c338e Frank van der Linden 2020-06-23 740 ssize_t buflen)
95ad37f90c338e Frank van der Linden 2020-06-23 741 {
95ad37f90c338e Frank van der Linden 2020-06-23 742 struct nfs4_xattr_cache *cache;
95ad37f90c338e Frank van der Linden 2020-06-23 743 struct nfs4_xattr_entry *entry;
95ad37f90c338e Frank van der Linden 2020-06-23 744
95ad37f90c338e Frank van der Linden 2020-06-23 745 cache = nfs4_xattr_get_cache(inode, 1);
99dd76e4af5d61 Javier Abrego 2022-05-20 746 if (cache == NULL) {
99dd76e4af5d61 Javier Abrego 2022-05-20 747 kref_put(&cache->ref, nfs4_xattr_free_cache_cb);
99dd76e4af5d61 Javier Abrego 2022-05-20 748 } else {
95ad37f90c338e Frank van der Linden 2020-06-23 749 /*
95ad37f90c338e Frank van der Linden 2020-06-23 750 * This is just there to be able to get to bucket->cache,
95ad37f90c338e Frank van der Linden 2020-06-23 751 * which is obviously the same for all buckets, so just
95ad37f90c338e Frank van der Linden 2020-06-23 752 * use bucket 0.
95ad37f90c338e Frank van der Linden 2020-06-23 753 */
95ad37f90c338e Frank van der Linden 2020-06-23 @754 entry->bucket = &cache->buckets[0];
95ad37f90c338e Frank van der Linden 2020-06-23 755
95ad37f90c338e Frank van der Linden 2020-06-23 756 if (!nfs4_xattr_set_listcache(cache, entry))
95ad37f90c338e Frank van der Linden 2020-06-23 757 kref_put(&entry->ref, nfs4_xattr_free_entry_cb);
99dd76e4af5d61 Javier Abrego 2022-05-20 758 }
95ad37f90c338e Frank van der Linden 2020-06-23 759 }
95ad37f90c338e Frank van der Linden 2020-06-23 760
--
0-DAY CI Kernel Test Service
https://01.org/lkp