Reply: [PATCH] mediatek/mt76: cleanup the code a bit

From: 赵军奎
Date: Thu May 19 2022 - 21:32:59 EST




-----邮件原件-----
发件人: Kalle Valo <kvalo@xxxxxxxxxx>
发送时间: 2022年5月18日 13:11
收件人: 赵军奎 <bernard@xxxxxxxx>
抄送: Felix Fietkau <nbd@xxxxxxxx>; Lorenzo Bianconi <lorenzo@xxxxxxxxxx>; Ryder Lee <ryder.lee@xxxxxxxxxxxx>; Shayne Chen <shayne.chen@xxxxxxxxxxxx>; Sean Wang <sean.wang@xxxxxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>; Matthias Brugger <matthias.bgg@xxxxxxxxx>; linux-wireless@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-mediatek@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; zhaojunkui2008@xxxxxxx
主题: Re: [PATCH] mediatek/mt76: cleanup the code a bit

> Bernard Zhao <bernard@xxxxxxxx> writes:

> > Function mt76_register_debugfs just call mt76_register_debugfs_fops
> > with NULL op parameter.
> > This change is to cleanup the code a bit, elete the meaningless
> > mt76_register_debugfs, and all call mt76_register_debugfs_fops.
> >
> > Signed-off-by: Bernard Zhao <bernard@xxxxxxxx>

> Please make the title more informative and don't use mediatek in the title, for example something like this:

> mt76: remove simple mt76_register_debugfs() function

> More info:

> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_title_is_wrong
Hi Kalle Valo:

Got this, I would resubmit a patch of V2 version, thank you very much!

BR//Bernard
> --
> https://patchwork.kernel.org/project/linux-wireless/list/

> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches