Re: [PATCH] random: convert to using fops->write_iter()

From: Jens Axboe
Date: Thu May 19 2022 - 20:32:10 EST


On 5/19/22 6:08 PM, Jason A. Donenfeld wrote:
> Hi Jens,
>
> On Thu, May 19, 2022 at 05:43:15PM -0600, Jens Axboe wrote:
>> -static int write_pool(const char __user *ubuf, size_t len)
>> +static size_t write_pool(struct iov_iter *iter)
>> {
>> size_t block_len;
>> int ret = 0;
>
> Changing the return value to size_t isn't quite right, as this can
> return -EFAULT. So at the very minimum, it should return a ssize_t.

Good catch, yes let's make that a ssize_t instead. Can you do that while
testing/applying?

--
Jens Axboe