Re: [PATCH] staging: r8188eu: prevent ->Ssid overflow in rtw_wx_set_scan()

From: Dan Carpenter
Date: Thu May 19 2022 - 13:17:07 EST


On Thu, May 19, 2022 at 05:45:31PM +0200, Greg KH wrote:
> On Wed, May 18, 2022 at 11:00:52AM +0400, Denis Efremov wrote:
> > This code has a check to prevent read overflow but it needs another
> > check to prevent writing beyond the end of the ->Ssid[] array.
> >
> > Fixes: 2b42bd58b321 ("staging: r8188eu: introduce new os_dep dir for RTL8188eu driver")
> > Cc: stable <stable@xxxxxxxxxxxxxxx>
> > Signed-off-by: Denis Efremov <denis.e.efremov@xxxxxxxxxx>
> > ---
> >
> > This patch is a copy of Dan's 74b6b20df8cf (CVE-2021-28660).
> > Drivers r8188eu and rtl8188eu share the same code.
>
> This does not apply to my tree at all. This file is not present anymore,
> what tree did you make it against?
>

That's weird. It applies fine for me on today's linux-next.

regards,
dan carpenter