Re: [PATCH v2] iio: vadc: Fix potential dereference of NULL pointer

[刘永志]

> -----Original Messages-----
> From: "Kalle Valo" <kvalo@xxxxxxxxxx>
> Sent Time: 2022-05-19 23:30:51 (Thursday)
> To: "Yongzhi Liu" <lyz_cs@xxxxxxxxxx>
> Cc: amitkarwar@xxxxxxxxx, ganapathi017@xxxxxxxxx, sharvari.harisangam@xxxxxxx, huxinming820@xxxxxxxxx, davem@xxxxxxxxxxxxx, edumazet@xxxxxxxxxx, kuba@xxxxxxxxxx, pabeni@xxxxxxxxxx, arend.vanspriel@xxxxxxxxxxxx, linux-wireless@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, fuyq@xxxxxxxxxxxxxx
> Subject: Re: [PATCH v2] iio: vadc: Fix potential dereference of NULL pointer
> 
> Yongzhi Liu <lyz_cs@xxxxxxxxxx> writes:
> 
> > The return value of vadc_get_channel() needs to be checked
> > to avoid use of NULL pointer. Fix this by adding the null
> > pointer check on prop.
> >
> > Fixes: 0917de94c ("iio: vadc: Qualcomm SPMI PMIC voltage ADC driver")
> >
> > Signed-off-by: Yongzhi Liu <lyz_cs@xxxxxxxxxx>
> > ---
> >  drivers/iio/adc/qcom-spmi-vadc.c | 23 ++++++++++++++++++++++-
> >  1 file changed, 22 insertions(+), 1 deletion(-)
> 

I'm sorry to send this to linux-wireless by mistake. I will cautiously submit patches later.

> Did you sent this to linux-wireless by mistake?
> 
> -- 
> https://patchwork.kernel.org/project/linux-wireless/list/
> 
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches