Re: [PATCH v2] binder: convert `BINDER_*` ioctl `#define`s into an `enum`

From: Greg Kroah-Hartman
Date: Thu May 19 2022 - 11:52:14 EST


On Wed, May 18, 2022 at 03:39:42PM +0200, Miguel Ojeda wrote:
> Hi Greg,
>
> On Tue, May 17, 2022 at 12:28 PM Miguel Ojeda <ojeda@xxxxxxxxxx> wrote:
> >
> > bindgen (a tool which generates the "raw" C bindings for Rust) only
> > works (so far) with "simple" C `#define`s. In order to avoid having
> > to manually maintain these constants in the (potential) Rust side,
> > this patch converts them into an `enum`.
>
> Given the discussion in v1's thread [0], I think we should hold on
> applying the patch (just letting you know here in v2).
>
> [0] https://lore.kernel.org/lkml/CANiq72=_UAF5DRHCmW4qNt-Wi3yV6vPEjdLhBTijG_ZGgfpaTA@xxxxxxxxxxxxxx/
>
> Cheers,
> Miguel

Yeah, I'll drop this from my queue, sorry.

greg k-h