Re: [PATCH net v2] net: wireless: marvell: mwifiex: fix sleep in atomic context bugs

[Jeff Johnson]

On 5/19/2022 8:14 AM, duoming@xxxxxxxxxx wrote:
> Hello,
>
> On Thu, 19 May 2022 17:58:47 +0300 Kalle Valo wrote:
>
> > > There are sleep in atomic context bugs when uploading device dump
> > > data on usb interface. The root cause is that the operations that
> > > may sleep are called in fw_dump_timer_fn which is a timer handler.
> > > The call tree shows the execution paths that could lead to bugs:
> > >
> > >     (Interrupt context)
> > > fw_dump_timer_fn
> > >    mwifiex_upload_device_dump
> > >      dev_coredumpv(..., GFP_KERNEL)

just looking at this description, why isn't the simple fix just to 
change this call to use GFP_ATOMIC?