Re: [PATCH 2/2] netfs: Export netfs_put_subrequest()

From: Jeff Layton
Date: Thu May 19 2022 - 11:38:50 EST


On Thu, 2022-05-19 at 15:16 +0100, David Howells wrote:
> Export netfs_put_subrequest() and a couple of tracepoints.
>
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
> cc: Jeff Layton <jlayton@xxxxxxxxxx>
> cc: linux-cachefs@xxxxxxxxxx
> ---
>
> fs/netfs/main.c | 3 +++
> fs/netfs/objects.c | 1 +
> 2 files changed, 4 insertions(+)
>
> diff --git a/fs/netfs/main.c b/fs/netfs/main.c
> index 068568702957..3d0283f8d0b9 100644
> --- a/fs/netfs/main.c
> +++ b/fs/netfs/main.c
> @@ -15,6 +15,9 @@ MODULE_DESCRIPTION("Network fs support");
> MODULE_AUTHOR("Red Hat, Inc.");
> MODULE_LICENSE("GPL");
>
> +EXPORT_TRACEPOINT_SYMBOL(netfs_rreq);
> +EXPORT_TRACEPOINT_SYMBOL(netfs_sreq);
> +
> unsigned netfs_debug;
> module_param_named(debug, netfs_debug, uint, S_IWUSR | S_IRUGO);
> MODULE_PARM_DESC(netfs_debug, "Netfs support debugging mask");
> diff --git a/fs/netfs/objects.c b/fs/netfs/objects.c
> index d6b8c0cbeb7c..cbc40d052b46 100644
> --- a/fs/netfs/objects.c
> +++ b/fs/netfs/objects.c
> @@ -160,3 +160,4 @@ void netfs_put_subrequest(struct netfs_io_subrequest *subreq, bool was_async,
> if (dead)
> netfs_free_subrequest(subreq, was_async);
> }
> +EXPORT_SYMBOL(netfs_put_subrequest);
>
>

I don't see any callers of this outside of netfs. What's the rationale
for exporting it?
--
Jeff Layton <jlayton@xxxxxxxxxx>