Re: [PATCH 06/10] rtw88: Add common USB chip support

[Sascha Hauer]

On Wed, May 18, 2022 at 10:34:58AM +0200, Johannes Berg wrote:
> On Wed, 2022-05-18 at 10:32 +0200, Sascha Hauer wrote:
> > 
> > >  	hw->wiphy->flags |= WIPHY_FLAG_SUPPORTS_TDLS |
> > > +			    WIPHY_FLAG_HAS_REMAIN_ON_CHANNEL |
> > >  			    WIPHY_FLAG_TDLS_EXTERNAL_SETUP;
> > 
> > This change should be in a separate patch. I don't have an idea though
> > what it's good for anyway. Is this change desired for the PCI variants
> > as well or only for USB? Do we want to have this change at all?
> > 
> 
> This driver uses mac80211, so that change should just not be there.
> mac80211 will set it automatically if it's possible, see in
> net/mac80211/main.c.

Ok, removing it doesn't seem to have any visible effect. I'll drop that
hunk for the next round.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |