Re: [PATCH 1/2] i2c: designware: introduce a custom scl recovery for SoCFPGA platforms

[Dinh Nguyen]

On 5/19/22 05:20, Andy Shevchenko wrote:
> On Wed, May 18, 2022 at 03:22:16PM -0500, Dinh Nguyen wrote:
> > The I2C pins on the SoCFPGA platforms do not go through a GPIO module,
> > thus cannot be recovered by the default method of by doing a GPIO access.
> > Only a reset of the I2C IP block can a recovery be successful.
>
> ...
>
> >   #define MODEL_BAIKAL_BT1	BIT(9)
> >   #define MODEL_AMD_NAVI_GPU	BIT(10)
> > +#define MODEL_SOCFPGA		BIT(11)
>
> ...
>
> > -#define MODEL_MASK		GENMASK(11, 8)
>
> > +#define MODEL_MASK		GENMASK(12, 8)
>
> Why this change is made?

Sorry, mistake here..will remove.

> ...
>
> > +	switch (dev->flags & MODEL_MASK) {
> > +	case MODEL_SOCFPGA:
> > +		rinfo->recover_bus = i2c_custom_scl_recovery;
>
> _custom_ is too broad, use exact name, i.e.
>
> 	i2c_socfpga_scl_recovery

Ok

> > +		break;
> > +	default:
> > +		rinfo->recover_bus = i2c_generic_scl_recovery;
> > +		break;
> > +	}
>
> ...
>
> > +	{ .compatible = "intel,socfpga-i2c", .data = (void *)MODEL_SOCFPGA },
>
> > +
>
> Stray change.

Will fix...

Thanks for the review!

Dinh
>