Re: [PATCH] Add an "-m" option to "perf buildid-list".

From: Ian Rogers
Date: Thu May 19 2022 - 00:47:56 EST


On Tue, May 10, 2022 at 11:13 AM Blake Jones <blakejones@xxxxxxxxxx> wrote:
>
> Thanks for taking a look at this!
>
> On Tue, May 10, 2022 at 9:46 AM Arnaldo Carvalho de Melo
> <acme@xxxxxxxxxx> wrote:
> > Em Tue, May 03, 2022 at 02:37:04PM -0700, Blake Jones escreveu:
> > > +-m::
> > > +--modules::
> > > + Show buildid, start/end text address, and path of kernel and modules.
> >
> > Hi,
> >
> > Wouldn't it be better to have -m show just modules, name +
> > buildid, then have -v show more verbose info, i.e. the start, end and
> > switch from just the module name to its full path?
> >
> > Then to get what your patch produces now one would use:
> >
> > $ perf buildid-list -kmv
> >
> > That would be more flexible, wdyt?
>
> I'm open to using "-v" like this if you think it would be useful; is
> there a use case you have in mind for the non-verbose mode? For doing
> external symbolization of stack traces, the BuildID isn't useful without
> also knowing the starting and ending addresses.
>
> If "-m" only showed information about modules and not about the kernel,
> then "perf buildid-list -km" (without "-v") would have different output
> formats for the kernel and for the modules. So I'm inclined to have "-m"
> include information about the kernel as well as the modules.
>
> How does that sound?
>
> Blake

Using "-m" sounds okay to me, Arnaldo?

Thanks,
Ian