Re: [PATCH v3] ext4: fix race condition between ext4_write and ext4_convert_inline_data

From: Theodore Ts'o
Date: Wed May 18 2022 - 21:29:34 EST


On Thu, 28 Apr 2022 21:40:31 +0800, Baokun Li wrote:
> Hulk Robot reported a BUG_ON:
> ==================================================================
> EXT4-fs error (device loop3): ext4_mb_generate_buddy:805: group 0,
> block bitmap and bg descriptor inconsistent: 25 vs 31513 free clusters
> kernel BUG at fs/ext4/ext4_jbd2.c:53!
> invalid opcode: 0000 [#1] SMP KASAN PTI
> CPU: 0 PID: 25371 Comm: syz-executor.3 Not tainted 5.10.0+ #1
> RIP: 0010:ext4_put_nojournal fs/ext4/ext4_jbd2.c:53 [inline]
> RIP: 0010:__ext4_journal_stop+0x10e/0x110 fs/ext4/ext4_jbd2.c:116
> [...]
> Call Trace:
> ext4_write_inline_data_end+0x59a/0x730 fs/ext4/inline.c:795
> generic_perform_write+0x279/0x3c0 mm/filemap.c:3344
> ext4_buffered_write_iter+0x2e3/0x3d0 fs/ext4/file.c:270
> ext4_file_write_iter+0x30a/0x11c0 fs/ext4/file.c:520
> do_iter_readv_writev+0x339/0x3c0 fs/read_write.c:732
> do_iter_write+0x107/0x430 fs/read_write.c:861
> vfs_writev fs/read_write.c:934 [inline]
> do_pwritev+0x1e5/0x380 fs/read_write.c:1031
> [...]
> ==================================================================
>
> [...]

Applied, thanks!

[1/1] ext4: fix race condition between ext4_write and ext4_convert_inline_data
commit: f87c7a4b084afc13190cbb263538e444cb2b392a

Best regards,
--
Theodore Ts'o <tytso@xxxxxxx>