On Wed, May 18, 2022 at 04:03:05AM +0800, Shuah Khan wrote:
I reviewed the patches and the test driver amd-pstate-ut doesn't belong under
selftests. I would recommend the following approach:
- add this test driver under drivers/cpufreq
- KUnit is a better fit for this unit test driver unless you want
to be able to run this without KUnit configured
- add the test script under selftests - the script then can load the
test driver and run tests and unload the driver.
Thanks Shuah. We would like to introduce more CPU benchmark testing based
the amd-pstate-ut next step, it may not be all the stuff in the kernel
module. E.X. use the script to trigger the tbench, gitsource, kernbench,
netperf, speedometer, and etc. testing and monitor the cpu frequency and
performance goals change, power consumption at runtime. Can the KUnit +
Kselftests work more straight forward in user scenario?