Re: [PATCH -next] fs-verity: remove unused parameter desc_size in fsverity_create_info()

From: Eric Biggers
Date: Wed May 18 2022 - 14:05:22 EST


On Wed, May 18, 2022 at 09:22:56PM +0800, Zhang Jianhua wrote:
> The parameter desc_size in fsverity_create_info() is useless and it is
> not referenced anywhere. The greatest meaning of desc_size here is to
> indecate the size of struct fsverity_descriptor and futher calculate the
> size of signature. However, the desc->sig_size can do it also and it is
> indeed, so remove it.
>
> Therefore, it is no need to acquire desc_size by fsverity_get_descriptor()
> in ensure_verity_info(), so remove the parameter desc_ret in
> fsverity_get_descriptor() too.
>
> Signed-off-by: Zhang Jianhua <chris.zjh@xxxxxxxxxx>
> ---
> fs/verity/enable.c | 2 +-
> fs/verity/fsverity_private.h | 6 ++----
> fs/verity/open.c | 12 ++++--------
> fs/verity/read_metadata.c | 5 ++---
> 4 files changed, 9 insertions(+), 16 deletions(-)

Applied, thanks!

- Eric