Re: [PATCH v3 3/4] can: skb:: move can_dropped_invalid_skb and can_skb_headroom_valid to skb.c

[Vincent MAILHOL]

On Thu. 19 May 2022 at 00:52, Max Staudt <max@xxxxxxxxx> wrote:
> On Thu, 19 May 2022 00:38:51 +0900
> Vincent MAILHOL <mailhol.vincent@xxxxxxxxxx> wrote:
>
> > On Wed. 18 May 2022 at 23:59, Oliver Hartkopp
> > <socketcan@xxxxxxxxxxxx> wrote:
> > > I can send a patch for this removal too. That's an easy step which
> > > might get into 5.19 then.
> >
> > OK, go ahead. On my side, I will start to work on the other changes
> > either next week or next next week, depending on my mood.
>
> Any wishes for the next version of can327/elmcan?

The only thing I guess would be to remove the check against
CAN_CTRLMODE_LISTENONLY in your xmit() function. The other things, I
already commented :)

> Should I wait until your changes are in?

I do not think you have to wait. There are no real dependencies. You
might just want to add a note after the --- scissors in the patch that
there is a weak dependencies on
https://lore.kernel.org/linux-can/20220514141650.1109542-5-mailhol.vincent@xxxxxxxxxx/


Yours sincerely,
Vincent Mailhol