Re: [PATCH v5 3/5] arm64: dts: qcom: sc7180: Add quackingstick dts files

From: Doug Anderson
Date: Wed May 18 2022 - 09:53:00 EST


Hi,

On Tue, May 10, 2022 at 3:46 PM Joseph S. Barrera III
<joebar@xxxxxxxxxxxx> wrote:
>
> Quackingstick is a trogdor-based board. These dts files are copies from
> the downstream Chrome OS 5.4 kernel, but with downstream bits removed.
>
> Signed-off-by: Joseph S. Barrera III <joebar@xxxxxxxxxxxx>
> Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
>
> ---
>
> Changes in v5:
> - Removed extra newline
> - Added comment that compatible will be filled in per-board
>
> Changes in v4:
> - Added missing version history
>
> Changes in v3:
> - First inclusion in this series
>
> arch/arm64/boot/dts/qcom/Makefile | 2 +
> .../sc7180-trogdor-quackingstick-r0-lte.dts | 38 ++
> .../qcom/sc7180-trogdor-quackingstick-r0.dts | 26 ++
> .../qcom/sc7180-trogdor-quackingstick.dtsi | 324 ++++++++++++++++++
> 4 files changed, 390 insertions(+)

Just so it doesn't get lost, I saw another downstream change fly by.
Since you already have to spin for v6, you should incorporate that
too:

https://crrev.com/c/3652958

-Doug