Re: [PATCH v2 3/3] PCI: qcom: Add system PM support

From: Christoph Hellwig
Date: Wed May 18 2022 - 09:24:15 EST


On Wed, May 18, 2022 at 06:49:13PM +0530, Manivannan Sadhasivam wrote:
> From: Prasad Malisetty <quic_pmaliset@xxxxxxxxxxx>
>
> Add suspend and resume callbacks to handle system suspend and resume in
> the Qcom PCIe controller driver. When the system suspends, PME turnoff
> message will be sent to the device and the RC driver will wait for the
> device to enter L23 Ready state. After that, the PHY will be powered down
> and clocks/regulators will be disabled.

So what about just not doing this stupid power disabling to start
with? Unlike x86 where we do not have choice due to the BIOS, we
apparently do here. And disabling power is the wrong thing to do at
least for SSDs as it massively increases the wear on the NAND.