Re: [PATCH v0] nfc: pn533: Fix buggy cleanup order

From: patchwork-bot+netdevbpf
Date: Wed May 18 2022 - 09:00:25 EST


Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@xxxxxxxxxxxxx>:

On Wed, 18 May 2022 18:53:21 +0800 you wrote:
> When removing the pn533 device (i2c or USB), there is a logic error. The
> original code first cancels the worker (flush_delayed_work) and then
> destroys the workqueue (destroy_workqueue), leaving the timer the last
> one to be deleted (del_timer). This result in a possible race condition
> in a multi-core preempt-able kernel. That is, if the cleanup
> (pn53x_common_clean) is concurrently run with the timer handler
> (pn533_listen_mode_timer), the timer can queue the poll_work to the
> already destroyed workqueue, causing use-after-free.
>
> [...]

Here is the summary with links:
- [v0] nfc: pn533: Fix buggy cleanup order
https://git.kernel.org/netdev/net/c/b8cedb7093b2

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html