Re: [PATCH 1/3] m68knommu: fix undefined reference to `mach_get_rtc_pll'

[Arnd Bergmann]

On Wed, May 18, 2022 at 7:56 AM Greg Ungerer <gerg@xxxxxxxxxxxxxx> wrote:
>
> Configuring for a nommu classic m68k target and enabling the generic rtc
> driver (CONFIG_RTC_DRV_GENERIC) will result in the following compile
> error:
>
>    m68k-linux-ld: arch/m68k/kernel/time.o: in function `rtc_ioctl':
>    time.c:(.text+0x82): undefined reference to `mach_get_rtc_pll'
>    m68k-linux-ld: time.c:(.text+0xbc): undefined reference to `mach_set_rtc_pll'
>    m68k-linux-ld: time.c:(.text+0xf4): undefined reference to `mach_set_rtc_pll'
>
> There is no definitions of "mach_set_rtc_pll" and "mach_get_rtc_pll" in the
> nommu code paths. Move these definitions and the associated "mach_hwclk",
> so that they are around their use case in time.c. This means they will
> always be defined on the builds that require them, and not on those that
> cannot use them - such as ColdFire (both with and without MMU enabled).
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Greg Ungerer <gerg@xxxxxxxxxxxxxx>

Right, this seems to be the best solution

Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>