Re: [PATCH v2 1/2] pinctrl: intel: make irq_chip immutable

[Mika Westerberg]

On Wed, May 18, 2022 at 12:05:38PM +0200, Andy Shevchenko wrote:
> On Wed, May 18, 2022 at 11:19 AM Mika Westerberg
> <mika.westerberg@xxxxxxxxxxxxxxx> wrote:
> > On Wed, May 18, 2022 at 11:46:06AM +0300, Andy Shevchenko wrote:
> > > On Wed, May 18, 2022 at 08:08:17AM +0300, Mika Westerberg wrote:
> > > > On Tue, May 17, 2022 at 07:38:19PM +0300, Andy Shevchenko wrote:
> > > > > +static const struct irq_chip intel_gpio_irq_chip = {
> > > > > + .name           = "intel-gpio",
> > > > > + .irq_ack        = intel_gpio_irq_ack,
> > > > > + .irq_mask       = intel_gpio_irq_mask,
> > > > > + .irq_unmask     = intel_gpio_irq_unmask,
> > > > > + .irq_set_type   = intel_gpio_irq_type,
> > > > > + .irq_set_wake   = intel_gpio_irq_wake,
> > > > > + .flags          = IRQCHIP_MASK_ON_SUSPEND | IRQCHIP_IMMUTABLE,
> > > > > + GPIOCHIP_IRQ_RESOURCE_HELPERS,
> > > > > +};
> > > >
> > > > You still have the inconsistent alignment here.
> > >
> > > I'm not sure what problem do you see.
> >
> > I mean the tab alignment you use:
> >
> >         .name           = "intel-gpio",
> >         .irq_ack        = intel_gpio_irq_ack,
> >         .irq_mask       = intel_gpio_irq_mask,
> >         .irq_unmask     = intel_gpio_irq_unmask,
> >         .irq_set_type   = intel_gpio_irq_type,
> >         .irq_set_wake   = intel_gpio_irq_wake,
> >
> > All the other struct initializations in the driver use this style (and I
> > prefer it too):
> >
> >         .name = "intel-gpio",
> >         .irq_ack = intel_gpio_irq_ack,
> >         .irq_mask = intel_gpio_irq_mask,
> >         .irq_unmask = intel_gpio_irq_unmask,
> >         .irq_set_type = intel_gpio_irq_type,
> >         .irq_set_wake = intel_gpio_irq_wake,
> >
> > Hope this explains.
> 
> Yes, thanks!
> 
> Okay, can you give your conditional Ack if there are no other
> comments? I will fix it locally.

Sure. There was typo also in the second patch $subject, please fix it
too while you apply them. For both,

Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>