Re: [PATCH 1/2] powerpc: Add generic PAGE_SIZE config symbols

From: Christophe Leroy
Date: Wed May 18 2022 - 05:42:56 EST




Le 05/05/2022 à 14:51, Michael Ellerman a écrit :
> Other arches (sh, mips, hexagon) use standard names for PAGE_SIZE
> related config symbols.
>
> Add matching symbols for powerpc, which are enabled by default but
> depend on our architecture specific PAGE_SIZE symbols.
>
> This allows generic/driver code to express dependencies on the PAGE_SIZE
> without needing to refer to architecture specific config symbols.

I guess next step should be to get rid of powerpc specific symbols and
use generic symbols instead.

We have (only) 111 occurences of it.


>
> Signed-off-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
> ---
> arch/powerpc/Kconfig | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index 145af02df3dc..02994361cc7a 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -759,6 +759,22 @@ config PPC_256K_PAGES
>
> endchoice
>
> +config PAGE_SIZE_4KB
> + def_bool y
> + depends on PPC_4K_PAGES
> +
> +config PAGE_SIZE_16KB
> + def_bool y
> + depends on PPC_16K_PAGES
> +
> +config PAGE_SIZE_64KB
> + def_bool y
> + depends on PPC_64K_PAGES
> +
> +config PAGE_SIZE_256KB
> + def_bool y
> + depends on PPC_256K_PAGES
> +
> config PPC_PAGE_SHIFT
> int
> default 18 if PPC_256K_PAGES