Re: [PATCH v2 1/6] dt-bindings: regulator: qcom,spmi-regulator: Convert to dtschema

From: Krzysztof Kozlowski
Date: Wed May 18 2022 - 03:45:53 EST


On 17/05/2022 22:58, Robert Marko wrote:
> On Tue, 17 May 2022 at 16:47, Krzysztof Kozlowski
> <krzysztof.kozlowski@xxxxxxxxxx> wrote:
>>
>> On 17/05/2022 13:59, Robert Marko wrote:
>>> Convert the bindings of Qualcomm SPMI regulators to DT schema.
>>>
>>> Signed-off-by: Robert Marko <robimarko@xxxxxxxxx>
>>> ---
>>> I am aware that syscon alone is not really acceptable, its converted
>>> directly from the old text bindings.
>>>
>>> There is also the issue of some MSM8994, MSM8996 and APQ8096 devices using
>>> '#address-cells', '#size-cells', some even defining reg property for
>>> regulators.
>>>
>>> Any advice on how to solve these issues is appreciated.
>>>
>>> Changes in v2:
>>
>> Changelog goes after ---
>
> Ok, will fix up in v3.
>
> While we are here,
> any ideas about the DTS-s that use reg and #address/size-cells for
> regulator subnodes and syscon?

Ideas for what exactly? It looks like a more of a subsystem convention,
whether to use unit addresses for children which are not real devices
(LEDs use unit addresses, regulators do not).

Best regards,
Krzysztof