Re: [PATCH -next] powerpc/book3e: Fix build error

[Michael Ellerman]

YueHaibing <yuehaibing@xxxxxxxxxx> writes:
> On 2022/5/17 18:45, Christophe Leroy wrote:
>> Le 17/05/2022 à 11:48, YueHaibing a écrit :
>>> arch/powerpc/mm/nohash/fsl_book3e.c: In function ‘relocate_init’:
>>> arch/powerpc/mm/nohash/fsl_book3e.c:348:2: error: implicit declaration of function ‘early_get_first_memblock_info’ [-Werror=implicit-function-declaration]
>>>    early_get_first_memblock_info(__va(dt_ptr), &size);
>>>    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>
>>> Add missing include file linux/of_fdt.h to fix this.
>>>
>>> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
>> 
>> Thats for fixing that.
>> 
>> Reviewed-by: Christophe Leroy <christophe.leroy@xxxxxxxxxx>
>> 
>> It means we don't have any defconfig for 32 bits booke with 
>> CONFIG_RELOCATABLE ?
>
> Indeed, there is no defconfig with CONFIG_RELOCATABLE under arch/powerpc/configs

It's selected by CRASH_DUMP, which is in ppc64_defconfig.

But it's not enabled in corenet32_smp_defconfig which is what I build,
or any of the other 85xx configs.

I guess it should be, I think it's true that RELOCATABLE=y exercises
more interesting code paths?

cheers