Re: [PATCH v9 2/3] dt-bindings: edac: nuvoton: add NPCM memory controller

From: Paul Menzel
Date: Wed May 18 2022 - 00:33:49 EST


Dear Medad,


Am 16.05.22 um 04:30 schrieb Medad Young:

Paul Menzel 於 2022年5月10日 週二 下午2:14寫道:

Am 10.05.22 um 05:10 schrieb Medad CChien:
Document devicetree bindings for the Nuvoton BMC NPCM memory controller.

Signed-off-by: Medad CChien <ctcchien@xxxxxxxxxxx>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
---
.../edac/nuvoton,npcm-memory-controller.yaml | 61 +++++++++++++++++++
1 file changed, 61 insertions(+)
create mode 100644 Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml

diff --git a/Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml b/Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml
new file mode 100644
index 000000000000..6f37211796a3
--- /dev/null
+++ b/Documentation/devicetree/bindings/edac/nuvoton,npcm-memory-controller.yaml
@@ -0,0 +1,61 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/edac/nuvoton,npcm-memory-controller.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Nuvoton NPCM Memory Controller
+
+maintainers:
+ - Medad CChien <ctcchien@xxxxxxxxxxx>

Just a side note, that in my experience functional like
<linux-npcm-memory-controller@xxxxxxxxxxx> instead of personal addresses
are useful, as you can configure on your side, who to deliver messages
to. For example, if you are on sick leave or vacation, you just
configure to deliver the message to a colleague of yours (or they get
messages in the first place anyway).

Maybe you can bring that up at Nuvoton.

I understand, but we do not have group email address.
so maybe I should add more maintainers?

If there are actually more maintainers, responsible and knowledgeable for that driver, than yes, these should be added (until you get a function address set up).


Kind regards,

Paul