Re: [PATCH 1/1] platform/chrome: check *dest of memcpy

From: Tzung-Bi Shih
Date: Tue May 17 2022 - 23:56:28 EST


On Tue, May 17, 2022 at 05:55:21PM +0800, Yuanjun Gong wrote:
> From: Gong Yuanjun <ruc_gongyuanjun@xxxxxxx>
>
> In regulator/cros-ec-regulator.c, cros_ec_cmd is sometimes called
> with *indata set to NULL.
>
> static int cros_ec_regulator_enable(struct regulator_dev *dev){
> ...
> cros_ec_cmd(data->ec_dev, 0, EC_CMD_REGULATOR_ENABLE, &cmd,
> sizeof(cmd), NULL, 0)
> ...}
>
> Don't do memcpy if indata is NULL.

The fix makes less sense to me. Did you find somewhere that `indata` is NULL
but `insize` is not 0?