Re: [PATCH net-next v4 05/12] dt-bindings: net: dsa: add bindings for Renesas RZ/N1 Advanced 5 port switch

From: Rob Herring
Date: Tue May 17 2022 - 21:59:38 EST


On Wed, May 11, 2022 at 06:33:37PM +0300, Vladimir Oltean wrote:
> On Wed, May 11, 2022 at 10:22:21AM -0500, Rob Herring wrote:
> > > +patternProperties:
> > > + "^ethernet-ports$":
> >
> > Move to 'properties', not a pattern.
> >
> > With that,
> >
> > Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
>
> Even if it should have been "^(ethernet-)?ports$"?

Why? Allowing 'ports' is for existing users. New ones don't need the
variability and should use just 'ethernet-ports'.

Rob