Re: [PATCH] gcc: fix -Warray-compare

From: Jakub Kicinski
Date: Tue May 17 2022 - 21:50:42 EST


On Tue, 17 May 2022 16:19:16 +0200 Martin Liška wrote:
> Subject: [PATCH] gcc: fix -Warray-compare

The subject should be more like

eth: sun: cassini: remove dead code

>
> Fixes the following GCC warning:
>
> drivers/net/ethernet/sun/cassini.c:1316:29: error: comparison between two arrays [-Werror=array-compare]
> drivers/net/ethernet/sun/cassini.c:3783:34: error: comparison between two arrays [-Werror=array-compare]

Because AFAICT this comparison will always be true:

#define CAS_HP_ALT_FIRMWARE cas_prog_null

Hopefully DaveM will correct if I'm getting this wrong :)