Re: [PATCH -next] net: ethernet: sunplus: add missing of_node_put() in spl2sw_mdio_init()

From: Jakub Kicinski
Date: Tue May 17 2022 - 20:47:52 EST


On Mon, 16 May 2022 22:37:34 +0800 Yang Yingliang wrote:
> of_get_child_by_name() returns device node pointer with refcount
> incremented. The refcount should be decremented before returning
> from spl2sw_mdio_init().
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>

Please add a Fixes tag, even if the change in question is only in
linux-next.

Wells Lu, the expectation for networking maintainers is that you will
review patches for your driver without 24, max 48 hours (not counting
weekends). Please respond with feedback or Acked-by / Reviewed-by tags
now that your driver has been merged. Thanks.